Allow resetting the status of multiple migrations #5287
Conversation
|
One thing I wasn't sure about is whether we should log Migration x is already Idle if passing the |
Yes lets omit those log messages. Less noise. |
DieterHolvoet
force-pushed
the
feature/migrate-reset-multiple
branch
from
eb49a02 to
6e3be62
Compare
|
Changed and rebased. |
| throw new \Exception(dt('You must specify --all, --tag, or one or more migration names separated by commas')); | ||
| } | ||
|
|
||
| if (!$list = $this->getMigrationList($migrationIds, $options['tag'])) { |
There was a problem hiding this comment.
We've already assign $options['tag'] to $tags. Why not use that var?
| $status = $migration->getStatus(); | ||
| if ($status !== MigrationInterface::STATUS_IDLE) { | ||
| $migration->setStatus(MigrationInterface::STATUS_IDLE); | ||
| $this->logger()->success(dt('Migration @id reset to Idle', ['@id' => $migrationId])); |
There was a problem hiding this comment.
Maybe Migration @id status reset to idle (added the "status" word)
| $migration->setStatus(MigrationInterface::STATUS_IDLE); | ||
| $this->logger()->success(dt('Migration @id reset to Idle', ['@id' => $migrationId])); | ||
| $tags = $options['tag']; | ||
| $all = $options['all']; |
There was a problem hiding this comment.
What happens if some are using:
--allwith--tagand some migration names?- but
--allwith--tag? - or
--allwith a list of migrations?
Maybe we should remove --all and NO MIGRATIONS == ALL? Then:
- no arguments, no options: All migrations
- only
--tag: All migrations filtered by provided tags - migration IDs +
--tag: should return error (or filter the list on tags?)
This PR adds the
allandtagoptions to themigrate:reset-statuscommand, together with the ability to pass a comma separated list of migration ids as argument.